-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize RLP length calculation #6729
Merged
benaadams
merged 6 commits into
NethermindEth:master
from
PaulusParssinen:rlp-length-optimizations
Feb 15, 2024
Merged
Optimize RLP length calculation #6729
benaadams
merged 6 commits into
NethermindEth:master
from
PaulusParssinen:rlp-length-optimizations
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulusParssinen
changed the title
Rlp length optimizations
Optimize RLP length calculation
Feb 14, 2024
PaulusParssinen
commented
Feb 14, 2024
Fails |
benaadams
approved these changes
Feb 15, 2024
benaadams
reviewed
Feb 15, 2024
} | ||
|
||
if (value < 256L * 256L * 256L * 256L * 256L * 256L * 256L) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wild set of if statements has always bothered me when I saw it
@PaulusParssinen thank you for your contribution |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
0 < value < 128
special case, should still be friendlier to the branch prediction and to the JIT.bswap
for 32-bit case and reduce remove few bounds-checks. We could also reduce bounds-checks for the 24-bit case but I thought this change more as a refactor to utilize the "new" built-in APIs.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
Notes on testing
All tests green locally.