Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for background JumpDestinationAnalysis if in progress #7008

Merged
merged 13 commits into from
May 14, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented May 10, 2024

Changes

  • If its already started processing it will likely finish before starting the processing from start will
  • Also replaced queued/received section in logs which are always 0, with from cache + analysed which is more interesting data

image

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams marked this pull request as ready for review May 10, 2024 23:22
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queues in logs are very useful in full sync or catching up to head.

@benaadams
Copy link
Member Author

The queues in logs are very useful in full sync or catching up to head.

Switch modes when the queues are empty?

image

@benaadams
Copy link
Member Author

Though not happy with scontracts as a term 😅

@benaadams
Copy link
Member Author

exec code from cache 982 | new 11 instead

image

@benaadams benaadams requested a review from LukaszRozmej May 12, 2024 16:33
@benaadams benaadams requested a review from LukaszRozmej May 13, 2024 12:35
@benaadams
Copy link
Member Author

Added odd/even for peers report as its frequent enough that can see both and too frequent to have both at same time (two lines)

image

@benaadams benaadams merged commit b27593c into master May 14, 2024
67 checks passed
@benaadams benaadams deleted the background-jmpdestanalysis branch May 14, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants