Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization/pre warm intra block cache fix nonce collisions #7089

Merged
merged 61 commits into from
Oct 24, 2024
Merged

Optimization/pre warm intra block cache fix nonce collisions #7089

merged 61 commits into from
Oct 24, 2024

Conversation

LukaszRozmej
Copy link
Member

Changes

  • Should fix nonce collisions when pre-loading block

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

LukaszRozmej and others added 30 commits May 21, 2024 01:32
@LukaszRozmej
Pre-warm intra block cache during block execution
4d33430
@LukaszRozmej
changes
b5e66a8
@LukaszRozmej
Seperate pre block cache from block cache
3bcceb3
@LukaszRozmej
add object pool, fix sharing state by warm-up processing
4de42a3
@LukaszRozmej
Add parallel options
65249c1
@LukaszRozmej
catch failures and add logging
d2b390b
@LukaszRozmej
use system transaction to avoid balance checks
24772fd
@LukaszRozmej
fix benchmarks
58e96a3
@LukaszRozmej
Merge remote-tracking branch 'origin/master' into optimization/pre-wa…
11e8734 
…rm-intra-block-cache
@LukaszRozmej
Clear caches post-block
c1ee96a
@LukaszRozmej
changes, version without shared dictionary
20ab0fc
@LukaszRozmej
temp changes
7c8c625
@benaadams
Bump cache
97183a0
@benaadams
Merge branch 'Bump-Cache' into optimization/pre-warm-intra-block-cache
0c7813a
@benaadams
CI
5d4cb66
@benaadams
Cache on
c4c4266
@benaadams
State only
0aaec9c
@LukaszRozmej
fixes
fcde05f
@LukaszRozmej
Merge remote-tracking branch 'origin/optimization/pre-warm-intra-bloc…
fb0902c 
…k-cache' into optimization/pre-warm-intra-block-cache

# Conflicts:
#	src/Nethermind/Nethermind.State/PersistentStorageProvider.cs
#	src/Nethermind/Nethermind.State/StateProvider.cs
@LukaszRozmej
revert unneeded changes
3486431
@benaadams
Fix cache metrics
1225d1c
@benaadams
state cache also
729c904
@benaadams
Use For rather than ForEach
3614e47
@LukaszRozmej
boost priority
e147789
@LukaszRozmej
Merge remote-tracking branch 'origin/optimization/pre-warm-intra-bloc…
1278b73 
…k-cache' into optimization/pre-warm-intra-block-cache

# Conflicts:
#	src/Nethermind/Nethermind.Consensus/Processing/IBlockCachePreWarmer.cs
@benaadams
Start a second tx
249074c
@benaadams
Parallel CodeCache
a528e28
@LukaszRozmej
fix CallAndRestore
c064d33
@LukaszRozmej
fix TrieStore creating block cache, causing issues
ff37457
@LukaszRozmej
add cache to TestBlockchain
3d60207
@benaadams benaadams marked this pull request as ready for review May 28, 2024 09:09
@LukaszRozmej LukaszRozmej requested a review from benaadams May 29, 2024 07:52
@LukaszRozmej
Copy link
Member Author

Can you give feedback how is it performing now?

benaadams
benaadams reviewed Sep 14, 2024
View reviewed changes
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be better to batch the txs from same sender and run them sequentially?

@benaadams
Copy link
Member

Would it not be better to batch the txs from same sender and run them sequentially?

Something more like this? #7467

@benaadams benaadams merged commit ebc0def into master Oct 24, 2024
75 checks passed
@benaadams benaadams deleted the optimization/pre-warm-intra-block-cache-nonce-collisions branch October 24, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukaszRozmej @benaadams