Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Eth module that exposes additional OP related fields #7096

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented May 28, 2024

Changes

  • Add OP specific fields to the receipts. They are different for deposit tx and the rest

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

@flcl42 flcl42 force-pushed the fix/op-receipts-rpc branch from db82fc5 to b0fd3ab Compare May 28, 2024 15:32
@flcl42 flcl42 force-pushed the fix/op-receipts-rpc branch from b0fd3ab to bd6a882 Compare May 28, 2024 15:43
@flcl42 flcl42 requested review from LukaszRozmej and asdacap May 28, 2024 15:43
@flcl42 flcl42 marked this pull request as ready for review May 28, 2024 15:44
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a bit overengeneered, couldn't we have OptimismEthRpcModule : IEthRpcModule and then return results with derived classes that can have different json serialization rules?

@flcl42
Copy link
Contributor Author

flcl42 commented May 29, 2024

@LukaszRozmej the latest commit a bit more complicated. But in addition to deduplication, I wanted to bring this PoC of abstracted key data structures. Maybe we can do the same with transactions, blocks, etc later

@flcl42 flcl42 force-pushed the fix/op-receipts-rpc branch 2 times, most recently from f999a2b to 4322d4f Compare May 29, 2024 08:19
@flcl42 flcl42 force-pushed the fix/op-receipts-rpc branch from 4322d4f to 183daf2 Compare May 29, 2024 08:26
@flcl42 flcl42 requested a review from LukaszRozmej May 29, 2024 19:30
@flcl42 flcl42 requested a review from LukaszRozmej May 31, 2024 14:47
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of would prefer composition for the module, but it is fine.

@flcl42
Copy link
Contributor Author

flcl42 commented Jun 5, 2024

I kind of would prefer composition for the module, but it is fine.

@LukaszRozmej I don't mind, but why?

@LukaszRozmej
Copy link
Member

I kind of would prefer composition for the module, but it is fine.

@LukaszRozmej I don't mind, but why?

Composition is always more flexible

@flcl42 flcl42 merged commit f91e27e into master Jun 5, 2024
68 checks passed
@flcl42 flcl42 deleted the fix/op-receipts-rpc branch June 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants