Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If worsevalue removed but not found, reinsert new worst item #7097

Merged
merged 1 commit into from
May 29, 2024
Merged

If worsevalue removed but not found, reinsert new worst item #7097

merged 1 commit into from
May 29, 2024

Conversation

benaadams
Copy link
Member

Resolves #6843

Changes

  • If a worst value is removed for the group, but wasn't in the group, readd a new worst value for the group

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • No

LukaszRozmej
LukaszRozmej approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @marcindsobczak review.

marcindsobczak
marcindsobczak approved these changes May 29, 2024 •
edited
Loading
View reviewed changes
@benaadams benaadams merged commit f97cd93 into master May 29, 2024
68 checks passed
@benaadams benaadams deleted the txpool branch May 29, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TxPool] TxPool limits break - it should keep 2048 tx at maximum
3 participants
@benaadams @LukaszRozmej @marcindsobczak