Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prague: Add support for getPayloadBodiesBy Hash + Range #7133

Merged
merged 31 commits into from
Jun 25, 2024

Conversation

rjnrohit
Copy link
Contributor

@rjnrohit rjnrohit commented Jun 4, 2024

Changes

This Introduces ExecutionPayloadBodyV2 to accommodate depositRequests and withdrawalRequests added to the payload body in Prague, more info: ethereum/execution-apis#545 , add tests for WithdrwalRequestProcessor and DepositProcessor and some optimizations.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@rjnrohit rjnrohit changed the base branch from master to feature/eip-7002_system_call June 4, 2024 10:10
@rjnrohit rjnrohit marked this pull request as ready for review June 11, 2024 18:04
@rjnrohit rjnrohit requested a review from MarekM25 June 11, 2024 18:04
@rjnrohit rjnrohit force-pushed the prague/get_payload_bodies branch from df2a765 to f27f610 Compare June 12, 2024 09:34
@rjnrohit rjnrohit requested review from rubo and a team as code owners June 12, 2024 09:34
@rjnrohit rjnrohit changed the base branch from feature/eip-7002_system_call to pectra_fix_conflicts June 12, 2024 09:35
Base automatically changed from pectra_fix_conflicts to pectra June 12, 2024 10:41
@rjnrohit rjnrohit force-pushed the prague/get_payload_bodies branch from f27f610 to 5156339 Compare June 12, 2024 11:34
@Scooletz
Copy link
Contributor

@rjnrohit Can you update the description of this PR?

@rjnrohit
Copy link
Contributor Author

@rjnrohit Can you update the description of this PR?

Updated, thanks!

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the list is a read-only in parameter or read-only result prefer IReadOnlyList over IList

@rjnrohit
Copy link
Contributor Author

rjnrohit commented Jun 24, 2024

if the list is a read-only in parameter or read-only result prefer IReadOnlyList over IList

Appropriately used, thanks!

@rjnrohit rjnrohit requested a review from MarekM25 June 25, 2024 17:40
@rjnrohit rjnrohit merged commit d6b1a95 into pectra Jun 25, 2024
62 checks passed
@rjnrohit rjnrohit deleted the prague/get_payload_bodies branch June 25, 2024 19:07
MarekM25 pushed a commit that referenced this pull request Sep 13, 2024
Co-authored-by: Rohit Ranjan <rohit@gigabyte.local>
Co-authored-by: MarekM25 <marekm2504@gmail.com>
(cherry picked from commit d6b1a95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants