Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap DotNetty Threads #7134

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Cap DotNetty Threads #7134

merged 1 commit into from
Jun 4, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Jun 4, 2024

Changes

Unbounded as there are 2 loops and the default is logical cores x 2; that can easily be 128 threads for consumer regular hardware or 512 threads for a top end Thread Ripper (2x2x128)

Steam hardware report from 2019

image

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams requested a review from LukaszRozmej June 4, 2024 11:18
@benaadams benaadams merged commit 3d532d1 into master Jun 4, 2024
68 checks passed
@benaadams benaadams deleted the dotnetty-threads branch June 4, 2024 11:21
@LukaszRozmej
Copy link
Member

@asdacap can you double check?

@asdacap
Copy link
Contributor

asdacap commented Jun 4, 2024

Should be fine. Saved a little memory probably. The message handling is capped to 1 thread by default anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants