Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't boost priority of forkchoice if syncing #7158

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Don't boost priority of forkchoice if syncing #7158

merged 1 commit into from
Jun 10, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Don't boost priority of forkchoice if syncing.
    • Apart from being no advantage
    • If syncing may go async and switch threads

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • No

@benaadams benaadams merged commit 1d6a536 into master Jun 10, 2024
68 checks passed
@benaadams benaadams deleted the syncing-boost-priority branch June 10, 2024 12:08
kamilchodola pushed a commit that referenced this pull request Jun 13, 2024
@benaadams @kamilchodola
Don't boost priority of forkchoice if syncing (#7158)
fdc9ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @smartprogrammer93