Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling fixes #7176

Merged
merged 7 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.chiseled
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN arch=$([ "$TARGETARCH" = "amd64" ] && echo "x64" || echo "$TARGETARCH") && \
dotnet publish src/Nethermind/Nethermind.Runner -c $BUILD_CONFIG -a $arch -o /publish --sc false \
-p:BuildTimestamp=$BUILD_TIMESTAMP -p:Commit=$COMMIT_HASH

# Creating these directiories here is needed to ensure the correct permissions
# Creating these directories here is needed to ensure the correct permissions
RUN cd /publish && \
mkdir keystore && \
mkdir logs && \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class CalculateRequestIdTest
[Test]
public void Calculates_RequestId_Correctly_No_Signature()
{
//todo: find another simialr transaction on a different network like holesky as goerli is being phased out.
//todo: find another similar transaction on a different network like holesky as goerli is being phased out.
//Using the following transaction as reference: https://goerli.etherscan.io/tx/0xa9236155292e30bfb43c5a758e0c906e18697cf23198f81e2a72e5322cd0acb7#eventlog
UserOperation userOperation = new(new UserOperationRpc
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public interface ISyncConfig : IConfig
public long AncientBodiesBarrierCalc => Math.Max(1, Math.Min(PivotNumberParsed, AncientBodiesBarrier));

[ConfigItem(Description = $$"""
The earliest receipt downloaded with fast sync when `{{nameof(DownloadReceiptsInFastSync)}}` is set to `true`. The actual value is determined as folows:
The earliest receipt downloaded with fast sync when `{{nameof(DownloadReceiptsInFastSync)}}` is set to `true`. The actual value is determined as follows:

```
max{ 1, min{ PivotNumber, max{ AncientBodiesBarrier, AncientReceiptsBarrier } } }
Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Cli/Modules/CliModuleLoader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private void LoadModule(CliModuleBase module)
if (cliModuleAttribute is null)
{
_cliConsole.WriteErrorLine(
$"Could not load module {module.GetType().Name} bacause of a missing {nameof(CliModuleAttribute)}.");
$"Could not load module {module.GetType().Name} because of a missing {nameof(CliModuleAttribute)}.");
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Consensus/MiningConfig.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public IBlocksConfig? BlocksConfig
{
get
{
// Lazt initalisation due to the awaiting of interface defaults application on assembly
// Last initialisation due to the awaiting of interface defaults application on assembly
_blocksConfig ??= new BlocksConfig();

return _blocksConfig;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public void RecoverData(Block block)
}
catch (Exception e)
{
if (_logger.IsError) _logger.Error($"An error occured while getting pending a transaction from TxPool, Transaction: {blockTransaction}", e);
if (_logger.IsError) _logger.Error($"An error occurred while getting a pending transaction from TxPool, Transaction: {blockTransaction}", e);
}

Address sender = transaction?.SenderAddress;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public long GetGasLimit(BlockHeader parentHeader)

long? targetGasLimit = _blocksConfig.TargetBlockGasLimit;
long newBlockNumber = parentHeader.Number + 1;
IReleaseSpec spec = _specProvider.GetSpec(newBlockNumber, parentHeader.Timestamp); // taking the parent timestamp is a temprory solution
IReleaseSpec spec = _specProvider.GetSpec(newBlockNumber, parentHeader.Timestamp); // taking the parent timestamp is a temporary solution
if (targetGasLimit is not null)
{
long maxGasLimitDifference = Math.Max(0, parentGasLimit / spec.GasLimitBoundDivisor - 1);
Expand Down