Replace JwtSecurityToken with JsonWebToken
#7177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartprogrammer93
approved these changes
Jun 12, 2024
smartprogrammer93
approved these changes
Jun 12, 2024
| @@ -10,7 +10,7 @@ namespace Nethermind.Sockets | |||
| public interface IWebSocketsModule | |||
| { | |||
| string Name { get; } | |||
| ISocketsClient CreateClient(WebSocket webSocket, string client, HttpContext context); | |||
| Task<ISocketsClient> CreateClient(WebSocket webSocket, string client, HttpContext context); | |||
There was a problem hiding this comment.
I would use valuetask as we won't need the task later
There was a problem hiding this comment.
One of the interface implementations added an await call. Thats why it was added
LukaszRozmej
approved these changes
Jun 13, 2024
| @@ -10,7 +10,7 @@ namespace Nethermind.Sockets | |||
| public interface IWebSocketsModule | |||
| { | |||
| string Name { get; } | |||
| ISocketsClient CreateClient(WebSocket webSocket, string client, HttpContext context); | |||
| Task<ISocketsClient> CreateClient(WebSocket webSocket, string client, HttpContext context); | |||
benaadams
approved these changes
Jun 13, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
JwtSecurityTokenwith the newJsonWebTokenthat's up to 30% faster, as Microsoft claimsJwtAuthentication.Authenticate()method async because of the underlying handler async API, which in turn caused chained async changes in several placesTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?