Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Lru tests #7178

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Increase Lru tests #7178

merged 2 commits into from
Jun 13, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Jun 13, 2024

Fix in #7160 broke hive tests; still haven't been able to track down the issue. However more tests is always good.

Break is state root mismatch

Processed block 8 (0x51bd5f...3159f4) is invalid: 
- hash: expected 0x63396b16dea8377d79ee68c1c1029a88315138025941d4815c0cfc033dbd5fc7, 
    got 0x51bd5f2998f8e2a5bdba8a15e5a8e8536ccadfd3bb4d776d94c1416b193159f4 
- state root: expected 0x9e0a7957b87f211e0aa26e6f0e4837c6fd23954ed76cce0e0e02c1f15590e157
      got 0xd942379f8376919d331a93825182e628c9ac4ab216cabb1ec495ae36084a833d 
- block extra data : 4e65746865726d696e64, UTF8: Nethermind 
Processed block is not valid 8 (0x63396b16dea8377d79ee68c1c1029a88315138025941d4815c0cfc033dbd5fc7) 
InvalidStateRoot: State root in header does not match. 

Changes

  • Increase testing for the Lru tests

Types of changes

What types of changes does your code introduce?

  • Other: Additional tests

Testing

Requires testing

  • No

If yes, did you write tests?

  • Yes

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are very hard to reason about

@benaadams
Copy link
Member Author

Those tests are very hard to reason about

😅 trying desperately to break something

@benaadams benaadams merged commit 7935979 into master Jun 13, 2024
68 checks passed
@benaadams benaadams deleted the lru-tests branch June 13, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants