-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consistent progress bars for syncing #7212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we started using some Pool of StringBuilders instead of string interpolation, would we reduce memory allocations significantly?
src/Nethermind/Nethermind.Synchronization/Reporting/SyncReport.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Synchronization/Reporting/SyncReport.cs
Outdated
Show resolved
Hide resolved
C#10 made string interpolation good https://devblogs.microsoft.com/dotnet/string-interpolation-in-c-10-and-net-6/ |
Changes
'⡀', '⡄', '⡆', '⡇', '⣇', '⣧', '⣷', '⣿'
Before
After
Types of changes
What types of changes does your code introduce?
Testing
Requires testing