Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nethermind as Optimism Sequencer #7287

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Conversation

emlautarom1
Copy link
Contributor

@emlautarom1 emlautarom1 commented Jul 24, 2024

Changes

  • Support running Nethermind as a sequencer when no Optimism sequencer URL is provided

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Documentation

Requires documentation update

  • Yes
  • No

We don't have an Optimism section on the Nethermind docs yet.

Requires explanation in Release Notes

  • Yes
  • No

Remarks

Used the following args.yaml file for the ethpandas optimism kurtosis package:

optimism_package:
  participants:
    - el_type: op-nethermind
      el_image: emlautarom1/op-nethermind
    - el_type: op-nethermind
      cl_type: op-node

The emlautarom1/op-nethermind image was built locally from this PRs branch using

docker build -t emlautarom1/op-nethermind -f Dockerfile .

Note that the Dockerfile.chiseled version does not work in this scenario.

public class OptimismEthRpcModuleTest
{
[Test]
public async Task Sequencer_send_transaction_with_signature_will_not_try_to_sign()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is pretty much a copy/paste of:

public async Task Send_transaction_with_signature_will_not_try_to_sign()

@emlautarom1 emlautarom1 marked this pull request as ready for review July 31, 2024 14:09
@emlautarom1 emlautarom1 merged commit 1605dd7 into master Jul 31, 2024
66 checks passed
@emlautarom1 emlautarom1 deleted the feat/optimism-sequencer branch July 31, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants