Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parallel signature recover #7353

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Improve parallel signature recover #7353

merged 1 commit into from
Aug 23, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Originally started to address an observed performance stall with Parallel.ForEach resolved by switching to Parallel.For (per element dispatch vs integer range). However on comparing again the stall wasn't observed; so will call this more a refactoring 😅

Types of changes

What types of changes does your code introduce?

  • Optimization
  • Refactoring

Testing

Requires testing

  • No

@benaadams benaadams requested a review from LukaszRozmej August 22, 2024 13:20
LukaszRozmej
LukaszRozmej approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we could make sure first few transactions are recovered and then, try recover the rest in the background, then wait for that in TransactionProdcessor, would be more parallel.

@benaadams benaadams merged commit c9960a1 into master Aug 23, 2024
66 checks passed
@benaadams benaadams deleted the parallel-signature-recover branch August 23, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej