Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes custom args validation and uses library one #7359

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Removes custom args validation and uses library one #7359

merged 3 commits into from
Aug 26, 2024

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Aug 25, 2024 •
edited
Loading

Changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej changed the title Parsing argument names with direct equals Removes custom validation and uses library one Aug 26, 2024
@LukaszRozmej LukaszRozmej requested a review from benaadams August 26, 2024 08:29
@LukaszRozmej LukaszRozmej changed the title Removes custom validation and uses library one Removes custom args validation and uses library one Aug 26, 2024
@LukaszRozmej LukaszRozmej merged commit ebdf27a into master Aug 26, 2024
66 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/parsing-argument-names-with-direct-equals branch August 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexb5dh alexb5dh alexb5dh left review comments

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukaszRozmej @benaadams @alexb5dh