Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for state override parameter in some RPC methods #7362

Merged
merged 86 commits into from
Nov 1, 2024
Merged

Support for state override parameter in some RPC methods #7362

merged 86 commits into from
Nov 1, 2024

Conversation

alexb5dh
Copy link
Contributor

@alexb5dh alexb5dh commented Aug 26, 2024 •
edited
Loading

Resolves #4021, resolves #6120, resolves #7306.

Changes

  • Support for state override set in the following RPC methods:
    • eth_call, eth_estimategas
    • trace_call
    • debug_traceCall
  • Makes following methods to run on top of the specified block instead of the previous one, similar to other clients:
    • trace_call, trace_callMany, trace_rawTransaction
    • debug_traceCall
  • Use corresponding factory to create module for TraceRpcModuleTests and DebugRpcModuleTests - to make it more consistent with regular setup.
  • Fixes double-serialization of some of the parameters in the RPC tests.

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • Yes

Documentation

Requires documentation update

  • Yes

Requires explanation in Release Notes

  • Yes, RPC changes should probably be included.

@alexb5dh alexb5dh self-assigned this Aug 26, 2024
@alexb5dh alexb5dh force-pushed the feature/rpc-state-override branch from 6cb949c to 00aae73 Compare September 1, 2024 00:55
@alexb5dh alexb5dh force-pushed the feature/rpc-state-override branch from 00aae73 to 363fdc9 Compare September 3, 2024 10:56
alexb5dh added 13 commits October 22, 2024 10:23
emlautarom1
emlautarom1 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Nethermind/Nethermind.Facade/BlockchainBridge.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthRpcModuleTests.EstimateGas.cs Outdated Show resolved Hide resolved
OlegJakushkin
OlegJakushkin approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@OlegJakushkin OlegJakushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! solves some issues on StateRoot in eth_simulate.

@alexb5dh alexb5dh merged commit 26a2e89 into master Nov 1, 2024
75 checks passed
@alexb5dh alexb5dh deleted the feature/rpc-state-override branch November 1, 2024 03:42
@kamilchodola kamilchodola restored the feature/rpc-state-override branch November 4, 2024 14:01
@alexb5dh alexb5dh deleted the feature/rpc-state-override branch November 4, 2024 14:56
@alexb5dh alexb5dh restored the feature/rpc-state-override branch November 4, 2024 14:56
@alexb5dh alexb5dh mentioned this pull request Nov 5, 2024
Merged
@kamilchodola kamilchodola deleted the feature/rpc-state-override branch November 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlautarom1 emlautarom1 emlautarom1 approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@OlegJakushkin OlegJakushkin OlegJakushkin approved these changes

@asdacap asdacap Awaiting requested review from asdacap

Assignees

@alexb5dh alexb5dh

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexb5dh @asdacap @OlegJakushkin @LukaszRozmej @emlautarom1