Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXTCODESIZE+POP #7437

Merged
merged 2 commits into from
Sep 16, 2024
Merged

EXTCODESIZE+POP #7437

merged 2 commits into from
Sep 16, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Sep 15, 2024 •
edited
Loading

Changes

  • EXTCODESIZE+POP => NOP; is a common pattern on a large patch of blocks in archive sync (Think it was an exploit). However don't actually need to access any data in this combination. Rather than looking up account and using that to load the code.
image

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams merged commit 0e1220c into master Sep 16, 2024
66 checks passed
@benaadams benaadams deleted the extcodesize branch September 16, 2024 08:14
deffrian pushed a commit that referenced this pull request Oct 28, 2024
@benaadams @deffrian
EXTCODESIZE+POP (#7437)
db7736e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej