EIP-7702 and EIP-7251 #7459

ak88 · 2024-09-18T12:00:28Z

https://eips.ethereum.org/EIPS/eip-7702
https://eips.ethereum.org/EIPS/eip-7251 (consolidations)

Changes

Adds an authorization_list to tx that is used to set delegations on EOAs in the form of 0xef0100 || address

When the EOA is called it is delegated to the address, in similar fashion as a DELEGATECALL.
EVM opcodes like EXTCODESIZE, EXTCODECOPY etc. are affected by a delegation.

Other things to note:

7702 delegations and refunds will happen regardless of EVM execution outcome.
Account access gas is changed to count double if delegated. Once for the EOA and once for the delegation address.

Types of changes

What types of changes does your code introduce?

Bugfix (a non-breaking change that fixes an issue)
New feature (a non-breaking change that adds functionality)
Breaking change (a change that causes existing functionality not to work as expected)
Optimization
Refactoring
Documentation update
Build-related changes
Other: Description

Testing

Requires testing

Yes
No

If yes, did you write tests?

Yes
No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

Yes
No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

Yes
No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Kamil Chodoła <43241881+kamilchodola@users.noreply.github.com> Co-authored-by: nethermind-machine <76107542+nethermind-machine@users.noreply.github.com> Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com> Co-authored-by: Daniel Kyutae Jung <45947071+pxyxyrus@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Amirul Ashraf <asdacap@gmail.com> Co-authored-by: yerke26 <160018032+yerke26@users.noreply.github.com> Co-authored-by: yeerke <ezhumalin01@gmail.com> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Alexey <me@flcl.me> Co-authored-by: Nikita Mescheryakov <root@nikitam.io> Co-authored-by: Lautaro Emanuel <31224949+emlautarom1@users.noreply.github.com> Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com> Co-authored-by: ak88 <anders@nethermind.io> Co-authored-by: Yaroslav Kukharuk <i.kukharuk@gmail.com> Co-authored-by: Marek Moraczyński <marekm2504@gmail.com> Co-authored-by: Ahmad Bitar <amb014@diyarme.com> Co-authored-by: Oleg Jakushkin <oleg.jakushkin@gmail.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: healthyyyoung <healthyoung@proton.me>

MarekM25 · 2024-10-02T18:08:25Z

src/Nethermind/Nethermind.Consensus/Requests/ConsensusRequestsProcessor.cs


-            requestsList.AddRange(_depositsProcessor.ProcessDeposits(block, receipts, spec));
-            requestsList.AddRange(_withdrawalRequestsProcessor.ReadWithdrawalRequests(block, state, spec));
+        using ArrayPoolList<ConsensusRequest> requestsList = new(receipts.Length * 2);


hmm, but block.Requests.Length will give us the correct capacity besides Invalid blocks, maybe block.Requests.Length *2 then?

receipts are not related to requests. We can have 3 receipts and 16 requests

LukaszRozmej

Few more small things

src/Nethermind/Ethereum.Test.Base/GeneralTestBase.cs

src/Nethermind/Ethereum.Test.Base/AuthorizationListJson.cs

src/Nethermind/Nethermind.Benchmark/Core/CodeInfoRepositoryBenchmark.cs

src/Nethermind/Nethermind.Benchmark/Core/RecoverSignaturesBenchmark.cs

src/Nethermind/Nethermind.Consensus.AuRa/InitializationSteps/InitializeBlockchainAuRa.cs

src/Nethermind/Nethermind.Consensus/Processing/RecoverSignature.cs

src/Nethermind/Nethermind.Consensus/Requests/RequestProcessor.cs

src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs

src/Nethermind/Nethermind.Optimism/OptimismEthereumEcdsa.cs

…e.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

Co-authored-by: MarekM25 <marekm2504@gmail.com> Co-authored-by: Rohit Ranjan <rohitrjn629@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Kamil Chodoła <43241881+kamilchodola@users.noreply.github.com> Co-authored-by: nethermind-machine <76107542+nethermind-machine@users.noreply.github.com> Co-authored-by: LukaszRozmej <LukaszRozmej@users.noreply.github.com> Co-authored-by: Daniel Kyutae Jung <45947071+pxyxyrus@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Amirul Ashraf <asdacap@gmail.com> Co-authored-by: yerke26 <160018032+yerke26@users.noreply.github.com> Co-authored-by: yeerke <ezhumalin01@gmail.com> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Alexey <me@flcl.me> Co-authored-by: Nikita Mescheryakov <root@nikitam.io> Co-authored-by: Lautaro Emanuel <31224949+emlautarom1@users.noreply.github.com> Co-authored-by: Marcos Antonio Maceo <35319980+stdevMac@users.noreply.github.com> Co-authored-by: Yaroslav Kukharuk <i.kukharuk@gmail.com> Co-authored-by: Ahmad Bitar <amb014@diyarme.com> Co-authored-by: Oleg Jakushkin <oleg.jakushkin@gmail.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: healthyyyoung <healthyoung@proton.me> Co-authored-by: Ahmad Bitar <smartprogrammer@windowslive.com>

MarekM25 and others added 30 commits May 8, 2024 22:44

resolved conflicts

fdd02ae

cosmetic

da6c886

fix validatorPubKey ->validatorPublicKey

2597b67

fix pubkey

59a05ee

fix DepositProcessorTests

60cc1b7

fix AUTH call gas costs

283f63b

RLP encoding

67ab80f

start test

2843085

refactor

bc8c3e9

Merge branch 'master' into pectra

147d69d

remove duplicate import

79ffe9d

Merge branch 'master' into pectra

1bb851d

Rename: ValidatorPublicKey -> ValidatorPubKey (#7172)

e1d3265

Remove support of eip3074 from pectra (#7189)

5262378

insert code in EOA

33652fc

removed wrong test

303a0f6

cleanup

de4d4d7

more tests added

4c591cc

Merge branch 'master' into feature/eip-7702

40903d1

more tests

f3c8a7d

refactor with CodeInfoRepo

c18c3d5

format whitespace

8a9cd0d

small refactor

bb6f5cf

refactor and unittest

bccfd21

Recover authority together with sender

a50c96c

added 7702 to metrics

6e91510

dont recover if already recovered

23a2936

Small changes

d1ef9dd

format whitespace

c1fd043

ak88 added 4 commits September 30, 2024 14:34

changes from review

e28f666

fix tests

2963ac2

refactor codeinforepo test

1be004e

base class for processors

eeb4ff9

ak88 requested a review from LukaszRozmej October 2, 2024 10:27

ak88 added 6 commits October 2, 2024 13:00

Merge branch 'master' into pectra_fix_7702_after_merge

096fb43

merge fix

facba02

comment correction

60348e2

Merge branch 'master' into pectra_fix_7702_after_merge

e4c49d3

format whitespace

86c9df2

benchmark fix

cd151cc

ak88 requested a review from MarekM25 October 2, 2024 11:32

small test change

347a63a

MarekM25 approved these changes Oct 2, 2024

View reviewed changes

LukaszRozmej requested changes Oct 3, 2024

View reviewed changes

MarekM25 and others added 9 commits October 3, 2024 12:18

Merge branch 'master' into pectra_fix_7702_after_merge

0087008

Update src/Nethermind/Nethermind.Consensus/Processing/RecoverSignatur…

464deeb

…e.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

Update src/Nethermind/Nethermind.Consensus/Processing/RecoverSignatur…

59a1ae2

…e.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

Update src/Nethermind/Nethermind.Consensus/Processing/RecoverSignatur…

4b51139

…e.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>

review changes

9f01cf2

use existing nulltxpool

0800ee3

format

7b51ea1

cosmetic

03db79c

Merge branch 'master' into pectra_fix_7702_after_merge

b60bc32

LukaszRozmej approved these changes Oct 7, 2024

View reviewed changes

ak88 merged commit e0c4a59 into master Oct 7, 2024
67 checks passed

ak88 deleted the pectra_fix_7702_after_merge branch October 7, 2024 14:00

emlautarom1 mentioned this pull request Oct 8, 2024

add EIP-7702 transactions and receipts ethereum/execution-apis#575

Open

rubo mentioned this pull request Dec 14, 2024

Remove Nethermind.Mev remnants #7911

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-7702 and EIP-7251 #7459

EIP-7702 and EIP-7251 #7459

ak88 commented Sep 18, 2024 •

edited

Loading

MarekM25 Oct 2, 2024

LukaszRozmej left a comment

EIP-7702 and EIP-7251 #7459

EIP-7702 and EIP-7251 #7459

Conversation

ak88 commented Sep 18, 2024 • edited Loading

Changes

Types of changes

What types of changes does your code introduce?

Testing

Requires testing

If yes, did you write tests?

Notes on testing

Documentation

Requires documentation update

Requires explanation in Release Notes

Remarks

MarekM25 Oct 2, 2024

Choose a reason for hiding this comment

LukaszRozmej left a comment

Choose a reason for hiding this comment

ak88 commented Sep 18, 2024 •

edited

Loading