Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix casting when tracing #7464

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix casting when tracing #7464

merged 1 commit into from
Sep 23, 2024

Conversation

LukaszRozmej
Copy link
Member

Changes

  • Removes unsafe casts when tracing

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej marked this pull request as ready for review September 19, 2024 12:31
benaadams
benaadams approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worried about api change for external consumers?

@LukaszRozmej
Copy link
Member Author

Worried about api change for external consumers?

shouldn't be that bad, not many external consumers

@LukaszRozmej LukaszRozmej merged commit a3bd523 into master Sep 23, 2024
66 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/trace-casting branch September 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukaszRozmej @benaadams