Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linea L2 #7555

Merged
merged 17 commits into from
Oct 21, 2024
Merged

Add Linea L2 #7555

merged 17 commits into from
Oct 21, 2024

Conversation

jmederosalvarado
Copy link
Member

Changes

  • Adds chainspec and configs for Linea L2

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Need to sync a few times to make sure everything works as expected

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@jmederosalvarado jmederosalvarado marked this pull request as ready for review October 17, 2024 13:31
@jmederosalvarado jmederosalvarado requested review from rubo and a team as code owners October 17, 2024 13:31
@jmederosalvarado jmederosalvarado force-pushed the feat/add-linea-configs branch 2 times, most recently from 7a19760 to 1f51591 Compare October 17, 2024 13:40
@kamilchodola
Copy link
Contributor

General comment:
Shouldn't each new config have default name for Metrics?
Like:
"Metrics": {
"NodeName": "Energy_Web"
},

?

@jmederosalvarado jmederosalvarado merged commit a1ca0fb into master Oct 21, 2024
74 checks passed
@jmederosalvarado jmederosalvarado deleted the feat/add-linea-configs branch October 21, 2024 05:57
@MarekM25 MarekM25 mentioned this pull request Nov 22, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants