-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flat encoding and requests as a side car #7557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethermind into feature/eip-7702
MarekM25
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments and here the most important:
have you tried to run devnet-4 fixtures from EF testing team?
src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.HelperFunctions.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.V4.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
rjnrohit
changed the title
add flat encoding and requests as a side car
Add flat encoding and requests as a side car
Oct 9, 2024
LukaszRozmej
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part review for now
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
rjnrohit
force-pushed
the
flat_requests
branch
from
October 15, 2024 07:40
137f260
to
5bd0edf
Compare
13 tasks
why merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7525
Closes #7524
Closes #7522
Resolves #7521
Changes
Implements changes from
engine: unified list of opaque requests execution-apis#577Types of changes
engine_getPayloadV4
andengine_getPayloadV4
, It incorporates suggestions from pectra-devnet4 doc, which was to exchangerequests
as a side car and remove them from the block bodyengine_getPayloadBodiesByRangeV2
andengine_getPayloadBodiesByHashV2
and all related objects and handlers, which are now obsolete.IExecutionRequestsProcess
and gets rid of all kinds of exiting requests processors.RequestsHash
calculation, more info at: https://eips.ethereum.org/EIPS/eip-7685What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Few more tests are yet to be written after a few rounds of discussions.
Documentation
Requires documentation update
Remarks
Please verify the
requestsHash
calculation, which should be done as follow: