-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BeaconBlockRootHandler #7604
Conversation
Can you explain why this is the issue? It is just AccessList creation, which shouldn't make a difference here if there is no contract? |
I checked geth implementation: |
Ok but Geth also uses access list but doesn't create the account? Something is off. |
Yes, here, before Evm call |
|
||
namespace Nethermind.Blockchain.BeaconBlockRoot; | ||
public class BeaconBlockRootHandler(ITransactionProcessor processor) : IBeaconBlockRootHandler | ||
{ | ||
private const long GasLimit = 30_000_000L; | ||
|
||
public (Address? toAddress, AccessList? accessList) BeaconRootsAccessList(Block block, IReleaseSpec spec, bool includeStorageCells = true) | ||
public (Address? toAddress, AccessList? accessList) BeaconRootsAccessList(Block block, IReleaseSpec spec, IWorldState stateProvider, bool includeStorageCells = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you pass StateProvider in constructor?
Fixes #7594
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.