Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Networking on OP/Base archive nodes #7778

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

kamilchodola
Copy link
Contributor

Networking was disabled on archive nodes which is invalid.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@kamilchodola kamilchodola marked this pull request as ready for review November 21, 2024 11:21
@kamilchodola kamilchodola changed the title Kch/enable networking op archive Enable Networking on OP/Base archive nodes Nov 21, 2024
@emlautarom1
Copy link
Contributor

Relevant: #6334

Could you elaborate on what changed that now we're enabling networking?

@kamilchodola
Copy link
Contributor Author

@emlautarom1
I believe disabling networking was done loong time ago on first implementations and since now we can connect by p2p properly we should have it enabled.

Also was a raised concern by one of users through slack channel.

@@ -10,11 +10,6 @@
"TxPool": {
"BlobsSupport": "Disabled"
},
"Sync": {
"NetworkingEnabled": false,
"AncientBodiesBarrier": 105235063,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barrier not needed anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - especially on archive config xD Not sure why it was even there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually learnt today about Regenesis of op-mainnet.
So reverted barriers

Copy link
Member

@jmederosalvarado jmederosalvarado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling Networking - Looks good

@kamilchodola kamilchodola merged commit 84dbd5a into master Nov 25, 2024
78 of 79 checks passed
@kamilchodola kamilchodola deleted the kch/enable_networking_op_archive branch November 25, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants