Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OP Holocene fork (retry) #7794

Merged
merged 48 commits into from
Nov 25, 2024
Merged

Add OP Holocene fork (retry) #7794

merged 48 commits into from
Nov 25, 2024

Conversation

emlautarom1
Copy link
Contributor

Reapplies #7761 without OP transitions

Changes

  • Support OP Holocene

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Node can now properly find peers.

Documentation

Requires documentation update

  • Yes
  • No

I don't think it's a requirement to update the docs.

Requires explanation in Release Notes

  • Yes
  • No

Remarks

When we started working on the Holocene fork PR, #7723 was still not included in master thus the OP transitions were part of the PR branch. Even after the transitions got removed, the Holocene PR still included them due to local changes thus when we merged it we reapplied them, causing Nethermind to not find nodes.

This PR is the same as #7761 but without the OP transitions included.

@emlautarom1 emlautarom1 merged commit f02b4e9 into master Nov 25, 2024
112 of 121 checks passed
@emlautarom1 emlautarom1 deleted the feat/optimism-holocene branch November 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants