Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for GetTrieNodesRequest disposing - debug check on ArrayPoolList #7862

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fixes for GetTrieNodesRequest disposing - debug check on ArrayPoolList #7862

merged 3 commits into from
Dec 18, 2024

Conversation

damian-orzechowski
Copy link
Contributor

Fix for ArrayPoolList hasn't been disposed. message - when handling GetTrieNodesRequest - only in Debug builds

Changes

  • Add IDisposable to GetTrieNodesRequest

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@damian-orzechowski damian-orzechowski marked this pull request as ready for review December 11, 2024 09:36
@damian-orzechowski damian-orzechowski merged commit 94815d5 into master Dec 18, 2024
79 checks passed
@damian-orzechowski damian-orzechowski deleted the fix/arraypoollist-not-disposed-debug branch December 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damian-orzechowski @LukaszRozmej