Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/skipped progress #7927

Merged
merged 18 commits into from
Dec 23, 2024
Merged

Feature/skipped progress #7927

merged 18 commits into from
Dec 23, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 18, 2024

  • Add skipped log to sync progress to indicate if a block already exist and is not downloaded.
  • This happens if bodies/receipts/headers already imported via era or beacon header restarted mid download.
  • MeasuredProgress -> ProgressLogger.

Type of change

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Works with era import

@asdacap asdacap mentioned this pull request Dec 19, 2024
5 tasks
@benaadams
Copy link
Member

Merge conflict

@asdacap
Copy link
Contributor Author

asdacap commented Dec 23, 2024

Fixed conflict

@asdacap asdacap merged commit 25dcec0 into master Dec 23, 2024
79 checks passed
@asdacap asdacap deleted the feature/skipped-progress branch December 23, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants