Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bls precompile: Use MUL for single point MSM #7931

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Marchhill
Copy link
Contributor

Changes

  • For MSM with a single point use MUL

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Covered by state tests

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@Marchhill Marchhill requested a review from MarekM25 December 18, 2024 15:23
@Marchhill Marchhill marked this pull request as ready for review December 18, 2024 18:16
@Marchhill
Copy link
Contributor Author

Note: duplicated MUL code as MUL will be removed here: #7932

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need this though? MSM should be good enough?

@Marchhill
Copy link
Contributor Author

Looks good. Do we need this though? MSM should be good enough?

It's more efficient this way as we don't have overhead of MSM

@Marchhill Marchhill merged commit 064421b into master Dec 20, 2024
79 checks passed
@Marchhill Marchhill deleted the perf/bls-msm-single-point branch December 20, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants