Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some closure allocations #7953

Merged
merged 9 commits into from
Dec 23, 2024
Merged

Remove some closure allocations #7953

merged 9 commits into from
Dec 23, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Avoid closure
  • Capture closure state in .ctor
  • Use try/catch rather than .ContinueWith for async Task
  • Change lambda sig to pass in value

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams merged commit bf0206d into master Dec 23, 2024
79 checks passed
@benaadams benaadams deleted the closure-allocations branch December 23, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdacap asdacap asdacap approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @asdacap