Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/verifytrie admin rpc #7962

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature/verifytrie admin rpc #7962

wants to merge 9 commits into from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 23, 2024 •
edited
Loading

  • As requested. admin_verifyTrie RPC.
  • Also, move blocking mechanism to TrieStore instead of processing queue.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Tested manually.
  • Tested to cancel on shutdown.
  • Tested to not run multiple verifytrie.

@asdacap asdacap requested a review from kamilchodola December 23, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asdacap