Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/remove tx processing env base #7967

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Refactor/remove tx processing env base #7967

merged 5 commits into from
Dec 27, 2024
+48 −67

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 24, 2024

  • The use of ReadOnlyTxProcessingEnvBase causes confusing subclass such as SimulateReadOnlyBlocksProcessingEnv which uses things that it does not need to use.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Unit tests passed

@asdacap asdacap mentioned this pull request Dec 24, 2024
Open
5 tasks
@asdacap asdacap merged commit 54c0739 into master Dec 27, 2024
79 checks passed
@asdacap asdacap deleted the refactor/remove-tx-processing-env-base branch December 27, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @LukaszRozmej