Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back signature by Vector512 rather than byte[] #8008

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Back signature by Vector512 rather than byte[] #8008

merged 4 commits into from
Jan 6, 2025

Conversation

benaadams
Copy link
Member

Changes

  • Drops one object reference per sig and Vector512 is smaller than byte[] with one less indirection

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams requested a review from LukaszRozmej January 5, 2025 08:12
@benaadams benaadams requested a review from LukaszRozmej January 5, 2025 13:20
@benaadams benaadams merged commit 910157b into master Jan 6, 2025
79 checks passed
@benaadams benaadams deleted the signature branch January 6, 2025 08:56
rjnrohit pushed a commit that referenced this pull request Jan 11, 2025
@benaadams @rjnrohit
Back signature by Vector512 rather than byte[] (#8008)
9a07a4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej