Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back Bloom with inline array rather than byte[] #8009

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Back Bloom with inline array rather than byte[] #8009

merged 1 commit into from
Jan 5, 2025

Conversation

benaadams
Copy link
Member

Changes

  • Drops one object reference per Bloom and inline array is smaller than byte[] with one less indirection

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams requested a review from LukaszRozmej January 5, 2025 08:39
@benaadams benaadams merged commit dc2051b into master Jan 5, 2025
79 checks passed
@benaadams benaadams deleted the bloom-inline branch January 5, 2025 12:17
@rubo
Copy link
Contributor

rubo commented Jan 5, 2025

Maybe not in this specific case with InlineArray, but good to know:

.NET 9 and later, the default implementations of Equals() and GetHashCode() for types marked with this attribute throw NotSupportedException. You must override both Equals(Object) and GetHashCode if they will be used.

rjnrohit pushed a commit that referenced this pull request Jan 11, 2025
@benaadams @rjnrohit
Back Bloom with inline array rather than byte[] (#8009)
e50539b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @rubo @LukaszRozmej