Create SimpleCall Example #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianhughes
force-pushed
the
CreateSimpleExample
branch
from
7901da4
to
fc66070
Compare
cicr99
reviewed
Jul 30, 2023
There was a problem hiding this comment.
It looks good.
I think it would be good to add the steps to run the example in examples/simpleCall/ReadMe.md.
Also, as the other examples are still not fixed, we could update the readme of the project to point to this example in particular. I think the others can be commented until they are fixed
rianhughes
force-pushed
the
CreateSimpleExample
branch
from
a0d9249
to
bba1d1b
Compare
cicr99
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a simple example to make a (read) contract call to a mainnet contract