New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block with tx hashes #354

Merged

rianhughes merged 4 commits into main from rpcv04_blockWithTxHashes

Sep 22, 2023

Contributor

cicr99 commented Sep 22, 2023

Closes #347

cicr99 added 2 commits

September 22, 2023 03:12


          create type for block with tx hashes

72cf46a


          remove transactionHash type

57da5e6

cicr99 requested a review from rianhughes

September 22, 2023 07:19

cicr99 self-assigned this

rianhughes reviewed

View reviewed changes

rpc/block_test.go Outdated Show resolved Hide resolved

rianhughes reviewed

View reviewed changes

rpc/block_test.go Outdated Show resolved Hide resolved

rianhughes reviewed

View reviewed changes

rpc/block_test.go Outdated Show resolved Hide resolved

rianhughes reviewed

View reviewed changes

rpc/block.go Show resolved Hide resolved

rianhughes reviewed

View reviewed changes

rpc/block.go Outdated Show resolved Hide resolved

cicr99 added 2 commits

September 22, 2023 10:44


          fix return value for Block methods

af0456a


          fix comments

0683e29

cicr99 requested a review from rianhughes

September 22, 2023 14:46

cicr99 mentioned this pull request

Specific return type for BlockWithTxs and BlockWithTxHashes methods #355

Open

rianhughes approved these changes

View reviewed changes

rianhughes merged commit 85352c1 into main

1 of 2 checks passed

rianhughes deleted the rpcv04_blockWithTxHashes branch

September 22, 2023 15:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet