Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Client does NOT close properly (neither do server connections) #44

Closed
john-bv opened this issue Jun 17, 2023 · 1 comment · Fixed by #35
Closed

bug: Client does NOT close properly (neither do server connections) #44

john-bv opened this issue Jun 17, 2023 · 1 comment · Fixed by #35
Labels
Bug Something isn't working Complete The code review for this issue has been completed; and is now being finalized.

Comments

@john-bv
Copy link
Member

john-bv commented Jun 17, 2023

Describe the bug
The Client and Connection structs both have an issue when communicating with eachother, that being, when the tasks are paused, there is no way to "wake them up" currently, meaning if a disconnect signal is received by the server, the other tasks will have no way of knowing that this signal was received causing a weird case where the connection freezes and has to wait for the connection timeout.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
These structs should dispatch signals properly to all tasks without any need for locking.

Screenshots
If applicable, add screenshots to help explain your problem.

Server versions (please complete the following information):

  • commit: [7189861]
  • Version: 0.3.0-rc-5
@john-bv john-bv added Bug Bug Something isn't working Minor This issue or PR contains minor changes and removed Bug labels Jun 17, 2023
john-bv added a commit that referenced this issue Aug 9, 2023
@john-bv john-bv added Complete The code review for this issue has been completed; and is now being finalized. and removed Minor This issue or PR contains minor changes labels Aug 10, 2023
@john-bv
Copy link
Member Author

john-bv commented Aug 10, 2023

This issue was completed with: d7c856a

@john-bv john-bv closed this as completed Aug 10, 2023
@john-bv john-bv linked a pull request Aug 21, 2023 that will close this issue
@NetrexMC NetrexMC locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Complete The code review for this issue has been completed; and is now being finalized.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant