Order of domain_name_servers and domain_name options matter

[milan-zededa]

I don't know if this is an intended behaviour or a bug, but the order of domain_name and domain_name_servers options for static configuration matters. In fact, domain name should be configured first, otherwise the list of DNS servers is not applied (or maybe gets reset?).

$ dhcpcd --version
dhcpcd 9.4.1
Copyright (c) 2006-2021 Roy Marples
Compiled in features: INET ARP ARPing IPv4LL INET6 DHCPv6 AUTH PRIVSEP

With domain name preceding DNS servers, it works as expected:

$ dhcpcd -d --static ip_address=192.168.1.20/24  -b -t 0 --static "domain_name=mydomain" --static "domain_name_servers=192.168.10.10 192.168.11.11" eth0
no such user dhcpcd
dhcpcd-9.4.1 starting
spawned manager process on PID 7406
DUID 00:01:00:01:2b:73:88:e1:02:fe:22:1a:87:00
forked to background, child pid 7406

$ dhcpcd -U -4 eth0
no such user dhcpcd
reason=STATIC
interface=eth0
protocol=dhcp
ip_address=192.168.1.20
subnet_cidr=24
broadcast_address=192.168.1.255
network_number=192.168.1.0
subnet_mask=255.255.255.0
domain_name=mydomain
domain_name_servers=192.168.10.10 192.168.11.11

However, if domain_name_servers are specified first, they will be ignored:

$ dhcpcd -d --static ip_address=192.168.1.20/24  -b -t 0 --static "domain_name_servers=192.168.10.10 192.168.11.11" --static "domain_name=mydomain" eth0
no such user dhcpcd
dhcpcd-9.4.1 starting
spawned manager process on PID 7297
DUID 00:01:00:01:2b:73:88:e1:02:fe:22:1a:87:00
forked to background, child pid 7297

$ dhcpcd -U -4 eth0
no such user dhcpcd
reason=STATIC
interface=eth0
protocol=dhcp
ip_address=192.168.1.20
subnet_cidr=24
broadcast_address=192.168.1.255
network_number=192.168.1.0
subnet_mask=255.255.255.0
domain_name=mydomain

Although I haven't tested dhcpcd with a configuration file, it seems that the same issue is also reproducible if config file is used instead of command line arguments, as reported in this comment.

[milan-zededa]

Thank you @rsmarples for fixing this so quickly!