Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add compatibility with Linux flavors with an old glibc #449

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,14 @@ jobs:
- os: macos-latest
target: macos
node: 18
# Using the `ubuntu-18.04` runner instead of latest (i.e. `ubuntu-22.04`)
# because G++/GCC 4.8 is not in an official repository yet.
# Using the `centos7-devtoolset7` runner instead of latest (i.e. `ubuntu-22.04`)
# with gcc 7 but glibc 2.17, so binaries are compatible for Ubuntu 14.04 and Debian 8.
- os: ubuntu-22.04
target: linux
container: ubuntu:18.04
node: 14
container:
image: centos/devtoolset-7-toolchain-centos7:7
options: "--user root"
runs-on: ${{ matrix.os }}
container: ${{ matrix.container }}
steps:
Expand All @@ -94,17 +96,9 @@ jobs:
- name: Install dev-deps
if: startsWith(matrix.os, 'ubuntu')
run: |
apt-get update -yq \
&& apt-get install build-essential python python-dev python3-pip g++-4.8 gcc-4.8 -yq \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

- name: Configures aliases to GCC/G++
if: startsWith(matrix.os, 'ubuntu')
run: |
update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.8 10 \
--slave /usr/bin/g++ g++ /usr/bin/g++-4.8 \
--slave /usr/bin/gcov gcov /usr/bin/gcov-4.8
yum install build-essential python3 -y \
&& yum clean all -y \
&& rm -rf /var/cache/yum

- name: Install deps
uses: ./.github/workflows/composite/npm
Expand Down
Loading