refactor(repeater): send errors to sentry #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsndr
force-pushed
the
refactor/send-errors-to-sentry
branch
from
49f0696 to
0133fae
Compare
lsndr
force-pushed
the
refactor/send-errors-to-sentry
branch
from
0133fae to
a6e6d79
Compare
|
This PR is ready to be reviewed, but not ready to be merged |
derevnjuk
reviewed
Sep 22, 2023
derevnjuk
changed the title
derevnjuk
added
Type: refactoring
derevnjuk
requested changes
Sep 22, 2023
derevnjuk
reviewed
Sep 25, 2023
lsndr
force-pushed
the
refactor/send-errors-to-sentry
branch
from
91df5f2 to
026e0f2
Compare
lsndr
force-pushed
the
refactor/send-errors-to-sentry
branch
from
d499b9a to
54609cf
Compare
derevnjuk
force-pushed
the
refactor/send-errors-to-sentry
branch
from
54609cf to
21ce83c
Compare
derevnjuk
reviewed
Oct 4, 2023
derevnjuk
force-pushed
the
refactor/send-errors-to-sentry
branch
from
c793f09 to
c9c640d
Compare
derevnjuk
pushed a commit
that referenced
this pull request
Oct 7, 2023
derevnjuk
pushed a commit
that referenced
this pull request
Oct 23, 2023
Some errors are logged in `printf`-like format, so despite we send all logged arguments to Sentry, the captured message is too generic. At the same time some passed logged arguments are being filtered by Sentry, which makes issue investigation harder. relates-to: #458
This was referenced Oct 26, 2023
derevnjuk
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.