Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of Sync channel for SpikeGLX and Open Ephys #1321

Closed
alejoe91 opened this issue Sep 1, 2023 · 1 comment · Fixed by #1327
Closed

Correct handling of Sync channel for SpikeGLX and Open Ephys #1321

alejoe91 opened this issue Sep 1, 2023 · 1 comment · Fixed by #1327
Labels

Comments

@alejoe91
Copy link
Contributor

alejoe91 commented Sep 1, 2023

Describe the bug
Both SpikeGLX and Open Ephys - Neuropix-PXI can optionally save a 385th SYNC channel in the binary file.

While both IOs have a load_sync_channel option, all cases are not currently handled. In particular:

  • SpikeGLX does not check wheter a SYNC channel is present, and just remove the last channel if load_sync_channel=False (see here).
  • Open Ephys handles it a bit betterr, BUT it doesn't throw an error if load_sync_channel=True, but not present in the data (same for SpikeGLX)

Expected behaviour
SpikeGLX and OpenEphys correctly handle the SYNC option of NP probes in a similar way, handling all possible cases.

Additional context
Currently on GIN we only have:

  • SpikeGLX with SYNC
  • OpenEphys without SYNC

We need to gather:

  • SpikeGLX without SYNC (any volunteer? @DradeAW ? )
  • Open Ephys with SYNC (I can get one)
@alejoe91 alejoe91 added the bug label Sep 1, 2023
@samuelgarcia
Copy link
Contributor

I do not think @DradeAW is the correct candidate for this because he is writting the thesis manuscript!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants