Unify and extend handling of Neuropixels SYNC channel

[alejoe91]

Fixes #1321

• Handles all options and combinations of SYNC channels in SpikeGLX and Open Ephys.
• Memmaps are sliced in the _get_analogsignal_chunk function, to be prepared for memmap refactoring #1265

TODO

• Add test files on GIN
  • SpikeGLX without SYNC
  • SpikeGLX with less than 384 channels
  • Open Ephys with SYNC
• Extend tests

[alejoe91]

@JuliaSprenger @samuelgarcia extended tests for SpikeGLX and Open Ephys using the newly added GIN files (https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/110)

Ready to review!

[alejoe91]

@samuelgarcia can you take a look at this? This is quite important on our side!

[samuelgarcia]

Merci.
I made on comments.
As a general feedback, variable name change make the PR very tedious to read and prevent focusing on the real change!

[pep8speaks]

Hello @alejoe91! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file neo/rawio/openephysbinaryrawio.py:

Line 156:25: E125 continuation line with same indent as next logical line
Line 533:68: E261 at least two spaces before inline comment
Line 538:100: E501 line too long (107 > 99 characters)
Line 566:68: E261 at least two spaces before inline comment

• In the file neo/rawio/spikeglxrawio.py:

Line 394:13: E125 continuation line with same indent as next logical line

• In the file neo/test/rawiotest/test_spikeglxrawio.py:

Line 35:100: E501 line too long (103 > 99 characters)
Line 44:100: E501 line too long (110 > 99 characters)
Line 54:100: E501 line too long (109 > 99 characters)
Line 66:100: E501 line too long (110 > 99 characters)
Line 70:100: E501 line too long (111 > 99 characters)
Line 80:100: E501 line too long (120 > 99 characters)

Comment last updated at 2023-11-16 14:19:34 UTC

[alejoe91]

@samuelgarcia tried to fix failing Maxwell tests, but that doesn't work.

On the spikeinterface side, setting an ENV variable in the GH action seems to work: SpikeInterface/spikeinterface#2161

Should I push something similar here?

Nevertheless, it's unrelated to this PR

[samuelgarcia]

Amazing work.