Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto push to pypi on push tags #1094

Conversation

samuelgarcia
Copy link
Contributor

@JuliaSprenger @apdavison @mdenker : have a look.
This auto push to pypi when we tag.
We have the same on spikeinertface.
Here we don't run the full io test which too long. Only the neo.core.
I think this is enough.

@apdavison
Copy link
Member

This is a definite no for me. We should not make a release until the full test suite passes (including IO) and the docs build correctly.

Also, this PR should target test.pypi.org.

If everything works, then we switch to the real PyPI.

@apdavison
Copy link
Member

also, shouldn't this only be for tags that match a specific pattern? tags aren't only used for releases.

@samuelgarcia
Copy link
Contributor Author

samuelgarcia commented Mar 8, 2022

Hi Andrew.
Thanks for the feedback.

  1. OK I will integrate the full test suite so with all dependencies.
  2. for teh doc, yes I forgot about it
  3. The test.pypi I never play with this, I don't figure out how to do this. I will investigate.
  4. For the tag pattern, yes we should do that. Any idea ?

@samuelgarcia
Copy link
Contributor Author

Also we should check that neo/version.py do not contain any '.dev0' as a security.

@JuliaSprenger JuliaSprenger linked an issue Mar 9, 2022 that may be closed by this pull request
5 tasks
@JuliaSprenger
Copy link
Member

@samuelgarcia Any updates on this? Would be nice to use this already for the next release :)

@JuliaSprenger JuliaSprenger added this to the 0.11.0 milestone Mar 31, 2022
@apdavison apdavison modified the milestones: 0.10.3, 0.11.0 Aug 30, 2022
@apdavison apdavison modified the milestones: 0.11.0, 0.12.0 Sep 29, 2022
@JuliaSprenger JuliaSprenger modified the milestones: 0.12.0, 0.12.1 Apr 2, 2023
@samuelgarcia
Copy link
Contributor Author

I propose to close and reopen something later

@JuliaSprenger JuliaSprenger modified the milestones: 0.12.1, 0.13.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add 'release' workflow to GH actions
3 participants