Fix another Plexon overflow + Limit Doc build to NumPy < 2.0 while we finish updating individual IOs #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay so the problem was casting behavior with numpy 2.0. So for docs I limited to < 2.0 because we depend on IOs and we have not updated the IOS yet. This is ready to go when tests pass @alejoe91. Heberto and I did this together to figure out it was a dependency issue. And this reminds me that each individual IO will need additional confirmation to be Numpy 2.0 ready. |
zm711
changed the title
zm711
changed the title
alejoe91
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alejoe91 I found another plexon overflow. could you merge this one. This is the problem with the documentation.
cc @h-mayorquin (this will fix the PR. I found another overflow).