Steepest edge #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting and updating of gamma values
…leau; implemented initialization. TODO: tests, implement update
…mma updates to inf and nan for some
…be and checked that it corresponds)
… - well, matlab - computed values)
…tting and updating of gamma values
…leau; implemented initialization. TODO: tests, implement update
…mma updates to inf and nan for some
…be and checked that it corresponds)
… - well, matlab - computed values)
guykatzz
reviewed
Jul 19, 2017
| @@ -82,6 +82,8 @@ class ITableau | |||
| virtual void computeMultipliers() = 0; | |||
| virtual void computeReducedCost( unsigned nonBasic ) = 0; | |||
| virtual const double *getCostFunction() const = 0; | |||
| // TODO: not sure if i'm allowed to add to this virtual class? | |||
guykatzz
reviewed
Jul 19, 2017
| * can update gamma more cheaply using a recurrence relation. See Goldfarb and Reid (1977), | ||
| * Forrest and Goldfarb (1992). | ||
| */ | ||
| return (c[j] * c[j]) / gamma[j]; |
There was a problem hiding this comment.
Are we sure gamma[j] isn't zero?
There was a problem hiding this comment.
It shouldn't be, because it's the weight of the vector p[j] (the direction the variable x moves in if you increment nonbasic variable Xj). We can add an ASSERT to be sure?
There was a problem hiding this comment.
Sure, let's add an assert
guykatzz
reviewed
Jul 19, 2017
src/reluplex/Tableau.cpp
Outdated
| _basisFactorization->forwardTransformation( ANColumnQ, invB_Aq ); | ||
|
|
||
| // Compute alphas and nus | ||
| double *alpha = new double[_n-_m]; |
There was a problem hiding this comment.
This memory needs to be deleted, I think.
If this is reallocated in every iteration, we can just allocate it once when the dimensions of the tableau are set, as "work memory". If we do that, we need to adjust their size when addRow() is invoked.
|
Please check if we need to update the gamma function in Tableau::performDegeneratePivot |
jjgold012
added a commit
that referenced
this pull request
Nov 28, 2019
yuvaljacoby
pushed a commit
to yuvaljacoby/Marabou-1
that referenced
this pull request
May 23, 2020
Merge Andrew's work
wu-haoze
added a commit
that referenced
this pull request
Aug 21, 2020
Changes towards satisfying the unit tests and runtime assertions
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented steepest edge pivot selection strategy (new selection rule in SteepestEdge.h; also modified Tableau to update data relevant to steepest edge before pivot operation)