Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: formatted with black #147

Merged
merged 17 commits into from
Mar 11, 2021
Merged

style: formatted with black #147

merged 17 commits into from
Mar 11, 2021

Conversation

ErikBjare
Copy link
Collaborator

@ErikBjare ErikBjare commented Mar 8, 2021 •
edited
Loading

Doing it all in a single commit (as discussed in #141 (comment)) and adding fmt: off/on where appropriate (so people can set up autoformatting of everything with black, and then forget about it).

An alternative PR to #141 #143 #144 #145

ErikBjare
ErikBjare commented Mar 8, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@ErikBjare
Copy link
Collaborator Author

CI fails with:

Run flake8
moabb/datasets/utils.py:17:1: C901 'dataset_search' is too complex (17)
Error: Process completed with exit code 1.

I'll give it a shot...

@sylvchev
Copy link
Member

sylvchev commented Mar 8, 2021

Yes, we ran into the same issue when deploying pre-commit and black :
we agree not to fix this error and simply ignoring it

@ErikBjare
Copy link
Collaborator Author

ErikBjare commented Mar 8, 2021 •
edited
Loading

@sylvchev Fixed it in fe2d489 (#147)

Ready to merge!

@ErikBjare ErikBjare marked this pull request as ready for review March 8, 2021 17:57
@ErikBjare ErikBjare requested a review from sylvchev March 8, 2021 18:01
sylvchev
sylvchev requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, nice! It could be merge soon.
Could you add a ignore-revs-file for avoiding wrong git blame?

moabb/analysis/plotting.py Outdated Show resolved Hide resolved
moabb/datasets/bnci.py Outdated Show resolved Hide resolved
moabb/datasets/ssvep_mamem.py Outdated Show resolved Hide resolved
moabb/tests/util_tests.py Outdated Show resolved Hide resolved
@sylvchev
Copy link
Member

@ErikBjare @v-goncharenko If that is ok with you, we could merge this one. I have a PR to open when this one is done 😃

@v-goncharenko
Copy link
Collaborator

@ErikBjare @v-goncharenko If that is ok with you, we could merge this one. I have a PR to open when this one is done 😃

Guess we need to resolve all the discussions. I'll make some additions in an hour

@v-goncharenko
Copy link
Collaborator

Added commits to resolve discussions.

I think we're ready!

@sylvchev sylvchev merged commit 11f5745 into master Mar 11, 2021
@v-goncharenko v-goncharenko deleted the dev/style-black branch March 23, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-goncharenko v-goncharenko v-goncharenko left review comments

@sylvchev sylvchev sylvchev approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikBjare @sylvchev @v-goncharenko