Restore basic logging #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somethings wrong with GitHub Actions, I frequently need to restart the workflows for no apparent reason. Maybe we could consider using only 3.6 for now and check all versions on new releases only? Or if we do create a dev branch, use only 3.6 there. |
|
Agree that we could try to limit the test during PR and apply a complete matrix of test before merging. |
sylvchev
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
This PR restores basic logging functionality using the python internal
loggingmodule instead of the removed coloredLogs.Additionally, the basic logger will now indicate the basic name of the module from which it was logged instead of showing
root.