-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save results immediately #422
base: develop
Are you sure you want to change the base?
Conversation
@bruAristimunha the code change should be quite simple I think (see my commits) but I don't have time now to test the parallel case and benchmark in the standard case. |
Okay, but now we lost all the results in the tutorials with this modification. We will need to debug this issue more to get it all green. |
I wonder if you could focus a little more on this problem in the CI, and then we could create a more specific test to work on the parallelization and overhead access issue. @PierreGtch |
I see it fails while testing the When I tested in local, the tests/evaluations.py were working fine |
Closes #419
Instead of waiting for the evaluation of a whole dataset to finish before saving the results, we could save them as soon as they are computed. Beneficial in case the evaluation fails in the middle.
Pending questions: