Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated deep learning #666

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

bruAristimunha
Copy link
Collaborator

As discussed #660, this deprecated and remove the module

Copy link
Collaborator

@PierreGtch PierreGtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bruAristimunha,
These files still contain references to braindecode, but maybe it was intentional. If not, which ones should we remove?

  • The CI test test-braindecode.yml
  • The optional poetry dependancy.
  • The benchmark moabb/benchmark
  • The pipelines:
    • pipelines/braindecode_EEGInception
    • pipelines/braindecode_EEGNetv4
    • pipelines/braindecode_ShallowFBCSPNet
    • pipelines/braindecode_Deep4Net
  • The examples:
    • examples/pipelines_braindecode/braindecode_EEGInception
    • examples/pipelines_braindecode/braindecode_EEGNetv4
    • examples/plot_benchmark_braindecode
    • examples/plot_barindecode
    • examples/load_model

@bruAristimunha
Copy link
Collaborator Author

We should keep The CI test-braindecode.yml, and remove the rest. I feel we should move one tutorial to braindecode itself, but I don't know which one.

@PierreGtch
Copy link
Collaborator

I think plot_baraindecode could be useful in braindecode

Copy link
Collaborator

@PierreGtch PierreGtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @bruAristimunha, less to maintain :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants