-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated deep learning #666
base: develop
Are you sure you want to change the base?
Deprecated deep learning #666
Conversation
…eprecated-deep-learning
# Conflicts: # moabb/tests/util_braindecode.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bruAristimunha,
These files still contain references to braindecode, but maybe it was intentional. If not, which ones should we remove?
- The CI test
test-braindecode.yml
- The optional poetry dependancy.
- The benchmark
moabb/benchmark
- The pipelines:
pipelines/braindecode_EEGInception
pipelines/braindecode_EEGNetv4
pipelines/braindecode_ShallowFBCSPNet
pipelines/braindecode_Deep4Net
- The examples:
examples/pipelines_braindecode/braindecode_EEGInception
examples/pipelines_braindecode/braindecode_EEGNetv4
examples/plot_benchmark_braindecode
examples/plot_barindecode
examples/load_model
# Conflicts: # moabb/tests/util_braindecode.py
We should keep The CI test-braindecode.yml, and remove the rest. I feel we should move one tutorial to braindecode itself, but I don't know which one. |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @bruAristimunha, less to maintain :D
As discussed #660, this deprecated and remove the module