Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Solving moabb and braindecode compatibility #669

Merged
merged 11 commits into from
Oct 24, 2024
Merged

[MNT] Solving moabb and braindecode compatibility #669

merged 11 commits into from
Oct 24, 2024

Conversation

bruAristimunha
Copy link
Collaborator

@bruAristimunha bruAristimunha commented Oct 23, 2024 •
edited
Loading

Related with braindecode and moabb issue, solved issue with:

  1. <class 'moabb.datasets.sosulski2019.Sosulski2019'>
  2. <class 'moabb.datasets.Zhou2016.Zhou2016'>
  3. <class 'moabb.datasets.liu2024.Liu2024'>
  4. <class 'moabb.datasets.mpi_mi.MunichMI'>
  5. <class 'moabb.datasets.upper_limb.Ofner2017'>
  6. <class 'moabb.datasets.physionet_mi.PhysionetMI'>

It may solve the issue with Schirrmeister2017, but I am not sure what is the issue, so, another PR.

@bruAristimunha
Copy link
Collaborator Author

Can you review @sebVelut?

@bruAristimunha bruAristimunha changed the title [MNT] Solving zhou braindecode compatibility [MNT] Solving Zhou and PhysionetMI braindecode compatibility Oct 23, 2024
@bruAristimunha bruAristimunha changed the title [MNT] Solving Zhou and PhysionetMI braindecode compatibility [MNT] Solving moabb and braindecode compatibility Oct 23, 2024
@bruAristimunha bruAristimunha merged commit 2f49da8 into NeuroTechX:develop Oct 24, 2024
12 checks passed
@bruAristimunha bruAristimunha deleted the solving-zhou-braindecode-side branch October 24, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebVelut sebVelut sebVelut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruAristimunha @sebVelut