Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect dtype for electrodes table filtering (float -> text) #478

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 14, 2021

Summary of changes

  • The electrodes table column "filtering" has dtype "float32" but is meant to store freeform text. The doc says "Description of hardware filtering, including the filter name and frequency cutoffs." The dtype should be "text".

PR checklist for schema changes

  • Update the version string in docs/format/source/conf.py, core/nwb.namespace.yaml, and /core/nwb.file.yaml
    to the next version with the suffix "-alpha"
  • Add a new section in the release notes for the new version with the date "Upcoming"
  • Add release notes for the PR to docs/format/source/format_release_notes.rst

@rly rly merged commit 72dcc72 into dev Jun 14, 2021
@rly rly deleted the fix/elec_filtering branch June 14, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants