Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cell_id to IntracellularElectrode #512

Merged
merged 6 commits into from
Apr 21, 2022
Merged

add cell_id to IntracellularElectrode #512

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
522290e
add cell_id to IntracellularElectrode
bendichter Apr 20, 2022
a804cba
Merge branch 'dev' into add/cell_id_to_intracellular_electrode
bendichter Apr 20, 2022
cb169b6
Update core/nwb.icephys.yaml
bendichter Apr 20, 2022
8be57f4
Update format_release_notes.rst
bendichter Apr 20, 2022
0ac4f36
Update format_release_notes.rst
bendichter Apr 20, 2022
b85b928
Merge branch 'dev' into add/cell_id_to_intracellular_electrode
bendichter Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/nwb.icephys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ groups:
neurodata_type_inc: NWBContainer
doc: An intracellular electrode and its metadata.
datasets:
- name: cell_id
dtype: text
doc: unique ID of the cell
quantity: '?'
- name: description
dtype: text
doc: Description of electrode (e.g., whole-cell, sharp, etc.).
Expand Down
3 changes: 2 additions & 1 deletion docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ Release Notes
Minor changes
^^^^^^^^^^^^^
- Added an ``offset`` attribute to all ``TimeSeries`` objects to allow enhanced translation to scientific units.
- Added ``cell_id`` field to ``IntracellularElectrode``. (#512)

Major changes
^^^^^^^^^^^^^
- Shape of SpatialSeries.data is more restrictive to prevent > 3 columns.
- Shape of SpatialSeries.data is more restrictive to prevent > 3 columns. (#510)


2.4.0 (Aug. 11, 2021)
Expand Down